[Webkit-unassigned] [Bug 153467] Sort incoming commits via date instead of revision number

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 25 17:05:28 PST 2016


--- Comment #2 from Dean Johnson <dean_johnson at apple.com> ---
Comment on attachment 269817
  --> https://bugs.webkit.org/attachment.cgi?id=269817

View in context: https://bugs.webkit.org/attachment.cgi?id=269817&action=review

r=me w/ passing tests! :)

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:200
> +            this.recordedCommits = newCommits.concat(this.recordedCommits).sort(function(a, b) { return a.date - b.date; });

I'm assuming this is the case, but just to be sure: these dates are either stored as integers or are data types that have logic to handle arithmetic operations and give correct results?

Actually, tests for this would completely eliminate my concern :)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160126/cd763f53/attachment.html>

More information about the webkit-unassigned mailing list