<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Sort incoming commits via date instead of revision number"
href="https://bugs.webkit.org/show_bug.cgi?id=153467#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Sort incoming commits via date instead of revision number"
href="https://bugs.webkit.org/show_bug.cgi?id=153467">bug 153467</a>
from <span class="vcard"><a class="email" href="mailto:dean_johnson@apple.com" title="Dean Johnson <dean_johnson@apple.com>"> <span class="fn">Dean Johnson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269817&action=diff" name="attach_269817" title="Patch">attachment 269817</a> <a href="attachment.cgi?id=269817&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269817&action=review">https://bugs.webkit.org/attachment.cgi?id=269817&action=review</a>
r=me w/ passing tests! :)
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:200
> + this.recordedCommits = newCommits.concat(this.recordedCommits).sort(function(a, b) { return a.date - b.date; });</span >
I'm assuming this is the case, but just to be sure: these dates are either stored as integers or are data types that have logic to handle arithmetic operations and give correct results?
Actually, tests for this would completely eliminate my concern :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>