[Webkit-unassigned] [Bug 145132] [ES6] Arrow function syntax. Arrow function specific features. Lexical bind "arguments"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145132

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269298|review?                     |review+
              Flags|                            |

--- Comment #56 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 269298
  --> https://bugs.webkit.org/attachment.cgi?id=269298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269298&action=review

r=me with one suggestion and a few comments:
Can you add a test to make sure it works with generators:
function* foo(a, b, c) {
    yield () => arguments;
}
foo(10, 20).value[0] === 10
foo(10, 20).value[1] === 20

> Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-strict.js:32
> +    // https://bugs.webkit.org/show_bug.cgi?id=152570

why does it lead to a reference error?

> Source/WebInspectorUI/UserInterface/Base/Object.js:63
> -        let wrappedCallback = () => {
> -            this.removeEventListener(eventType, wrappedCallback, null);
> +        let that = this;
> +        let wrappedCallback = function () {
> +            that.removeEventListener(eventType, wrappedCallback, null);

why is this necessary?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160123/b7bad63c/attachment-0001.html>