<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Arrow function specific features. Lexical bind "arguments""
href="https://bugs.webkit.org/show_bug.cgi?id=145132">bug 145132</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #269298 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Arrow function specific features. Lexical bind "arguments""
href="https://bugs.webkit.org/show_bug.cgi?id=145132#c56">Comment # 56</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Arrow function specific features. Lexical bind "arguments""
href="https://bugs.webkit.org/show_bug.cgi?id=145132">bug 145132</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269298&action=diff" name="attach_269298" title="Patch">attachment 269298</a> <a href="attachment.cgi?id=269298&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269298&action=review">https://bugs.webkit.org/attachment.cgi?id=269298&action=review</a>
r=me with one suggestion and a few comments:
Can you add a test to make sure it works with generators:
function* foo(a, b, c) {
yield () => arguments;
}
foo(10, 20).value[0] === 10
foo(10, 20).value[1] === 20
<span class="quote">> Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-arguments-strict.js:32
> + // <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function. Arrow function should raise exception ReferenceError only when access to 'arguments' in strict mode"
href="show_bug.cgi?id=152570">https://bugs.webkit.org/show_bug.cgi?id=152570</a></span >
why does it lead to a reference error?
<span class="quote">> Source/WebInspectorUI/UserInterface/Base/Object.js:63
> - let wrappedCallback = () => {
> - this.removeEventListener(eventType, wrappedCallback, null);
> + let that = this;
> + let wrappedCallback = function () {
> + that.removeEventListener(eventType, wrappedCallback, null);</span >
why is this necessary?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>