[Webkit-unassigned] [Bug 153292] AX: [IOS] Implement next/previous text marker functions using TextIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153292

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 269409
  --> https://bugs.webkit.org/attachment.cgi?id=269409
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269409&action=review

> Source/WebCore/ChangeLog:11
> +        Also, fixed an issue in AXObjectCache that creating a range with a replaced node

AXObjectCache that creating - >AXObjectCache where creating

did you add a test case for this issue you fixed?

> Source/WebCore/accessibility/AXObjectCache.cpp:1551
> +    

remove unused line

> Source/WebCore/accessibility/AXObjectCache.cpp:1577
> +    bool startNodeIsReplacedOrBR = AccessibilityObject::replacedNodeNeedsCharacter(startNode) || startNode->hasTagName(brTag);

can you put this code block in a helper method

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2506
> +    if (!start || !end)

can you make a helper method in WebAccessibilityTextMarker that takes a Range and returns an array of the WebAccessibilityTextMarker

> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:485
> +    return 0;

return nullptr;

> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:490
> +    return 0;

return nullptr;

> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:495
> +    return 0;

return nullptr;

> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:535
> +    return 0;

return nullptr;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160121/36fb3506/attachment.html>