<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [IOS] Implement next/previous text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=153292#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [IOS] Implement next/previous text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=153292">bug 153292</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269409&action=diff" name="attach_269409" title="patch">attachment 269409</a> <a href="attachment.cgi?id=269409&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269409&action=review">https://bugs.webkit.org/attachment.cgi?id=269409&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:11
> + Also, fixed an issue in AXObjectCache that creating a range with a replaced node</span >
AXObjectCache that creating - >AXObjectCache where creating
did you add a test case for this issue you fixed?
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:1551
> + </span >
remove unused line
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:1577
> + bool startNodeIsReplacedOrBR = AccessibilityObject::replacedNodeNeedsCharacter(startNode) || startNode->hasTagName(brTag);</span >
can you put this code block in a helper method
<span class="quote">> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2506
> + if (!start || !end)</span >
can you make a helper method in WebAccessibilityTextMarker that takes a Range and returns an array of the WebAccessibilityTextMarker
<span class="quote">> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:485
> + return 0;</span >
return nullptr;
<span class="quote">> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:490
> + return 0;</span >
return nullptr;
<span class="quote">> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:495
> + return 0;</span >
return nullptr;
<span class="quote">> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:535
> + return 0;</span >
return nullptr;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>