[Webkit-unassigned] [Bug 152913] Refactor compareIterations to remove duplicate code.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152913

--- Comment #9 from Jason Marcell <jmarcell at apple.com> ---
(In reply to comment #6)
> Comment on attachment 268981 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268981&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:48
> > +        queue = new MockBuildbotQueue();
> 
> This is error prone. Specifically, it is error prone to pass module state
> using global variables. From looking at the examples for setup()/tearDown()
> on <http://qunitjs.com/upgrade-guide-2.x/> and beforeEach()/afterEach() on
> <http://api.qunitjs.com/QUnit.module/> the preferred way to share such state
> is by modifying |this|.

I addressed in the latest patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160120/b4edf4ed/attachment.html>