<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor compareIterations to remove duplicate code."
href="https://bugs.webkit.org/show_bug.cgi?id=152913#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor compareIterations to remove duplicate code."
href="https://bugs.webkit.org/show_bug.cgi?id=152913">bug 152913</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152913#c6">comment #6</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=268981&action=diff" name="attach_268981" title="Patch">attachment 268981</a> <a href="attachment.cgi?id=268981&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=268981&action=review">https://bugs.webkit.org/attachment.cgi?id=268981&action=review</a>
>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:48
> > + queue = new MockBuildbotQueue();
>
> This is error prone. Specifically, it is error prone to pass module state
> using global variables. From looking at the examples for setup()/tearDown()
> on <<a href="http://qunitjs.com/upgrade-guide-2.x/">http://qunitjs.com/upgrade-guide-2.x/</a>> and beforeEach()/afterEach() on
> <<a href="http://api.qunitjs.com/QUnit.module/">http://api.qunitjs.com/QUnit.module/</a>> the preferred way to share such state
> is by modifying |this|.</span >
I addressed in the latest patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>