[Webkit-unassigned] [Bug 152181] Refactoring HTMLMediaElement getStartDate() implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 18 19:19:33 PST 2016


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #268284|review?                     |review-
              Flags|                            |

--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 268284
  --> https://bugs.webkit.org/attachment.cgi?id=268284
For testing

View in context: https://bugs.webkit.org/attachment.cgi?id=268284&action=review

> Source/WebCore/bindings/js/JSDOMBinding.cpp:120
>  JSValue jsDateOrNaN(ExecState* exec, double value)
>  {
> -    if (std::isnan(value))
> -        return jsDoubleNumber(value);
> -    return jsDateOrNull(exec, value);
> +    return DateInstance::create(exec->vm(), exec->lexicalGlobalObject()->dateStructure(), value);
>  }

If this function no longer returns a NaN when passed a NaN, then it should not be named jsDateOrNaN. We should not change what it does without changing its name.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160119/09cb5c74/attachment.html>

More information about the webkit-unassigned mailing list