<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactoring HTMLMediaElement getStartDate() implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=152181">bug 152181</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #268284 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactoring HTMLMediaElement getStartDate() implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=152181#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactoring HTMLMediaElement getStartDate() implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=152181">bug 152181</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268284&action=diff" name="attach_268284" title="For testing">attachment 268284</a> <a href="attachment.cgi?id=268284&action=edit" title="For testing">[details]</a></span>
For testing
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268284&action=review">https://bugs.webkit.org/attachment.cgi?id=268284&action=review</a>
<span class="quote">> Source/WebCore/bindings/js/JSDOMBinding.cpp:120
> JSValue jsDateOrNaN(ExecState* exec, double value)
> {
> - if (std::isnan(value))
> - return jsDoubleNumber(value);
> - return jsDateOrNull(exec, value);
> + return DateInstance::create(exec->vm(), exec->lexicalGlobalObject()->dateStructure(), value);
> }</span >
If this function no longer returns a NaN when passed a NaN, then it should not be named jsDateOrNaN. We should not change what it does without changing its name.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>