[Webkit-unassigned] [Bug 146934] [ES6] Arrow function syntax. Arrow function should support the destructuring parameters.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146934

--- Comment #11 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 268951
  --> https://bugs.webkit.org/attachment.cgi?id=268951
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268951&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:382
>> +        return isArrowFunction;
> 
> I would write this like:
> ```
> if (match(EOFTOK))
>     return false;
> bool isOpenParen = match(OPENPAREN);
> bool isIdent = match(IDENT);
> if (!isOpenParen && !isIdent)
>     return false;
> ```
> Then, below, you can use these booleans instead of performing the match(...) twice.
> I say this because I think that LLVM will CSE this, but lets take matters into our own hand.

This condition is refactored

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160116/dffeec91/attachment.html>