<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Arrow function should support the destructuring parameters."
href="https://bugs.webkit.org/show_bug.cgi?id=146934#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Arrow function should support the destructuring parameters."
href="https://bugs.webkit.org/show_bug.cgi?id=146934">bug 146934</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=268951&action=diff" name="attach_268951" title="Patch">attachment 268951</a> <a href="attachment.cgi?id=268951&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268951&action=review">https://bugs.webkit.org/attachment.cgi?id=268951&action=review</a>
<span class="quote">>> Source/JavaScriptCore/parser/Parser.cpp:382
>> + return isArrowFunction;
>
> I would write this like:
> ```
> if (match(EOFTOK))
> return false;
> bool isOpenParen = match(OPENPAREN);
> bool isIdent = match(IDENT);
> if (!isOpenParen && !isIdent)
> return false;
> ```
> Then, below, you can use these booleans instead of performing the match(...) twice.
> I say this because I think that LLVM will CSE this, but lets take matters into our own hand.</span >
This condition is refactored</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>