[Webkit-unassigned] [Bug 153185] Remove TextRun::allowsRoundingHacks()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 16 12:53:54 PST 2016


--- Comment #1 from Myles C. Maxfield <mmaxfield at apple.com> ---
(In reply to comment #0)
> TextRun::allowsRoundingHacks() and callers seem to be unused. It's exposed
> as WebView SPI, but no-one seems to use it. It's also exposed in Internals.

It looks like Internals::resetToConsistentState() calls TextRun::setAllowsRoundingHacks(false) thereby forcibly disabling all rounding hacks for all layout tests.

There are some callers (RenderTheme, RenderFileUploadControl) who try to use rounding hacks; allowing them to use rounding hacks in LayoutTests will cause behavior change.

In the interest of testing what we're shipping, it seems that we should remove the flag and rebaseline the tests.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160116/d35cce0d/attachment.html>

More information about the webkit-unassigned mailing list