<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove TextRun::allowsRoundingHacks()"
href="https://bugs.webkit.org/show_bug.cgi?id=153185#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove TextRun::allowsRoundingHacks()"
href="https://bugs.webkit.org/show_bug.cgi?id=153185">bug 153185</a>
from <span class="vcard"><a class="email" href="mailto:mmaxfield@apple.com" title="Myles C. Maxfield <mmaxfield@apple.com>"> <span class="fn">Myles C. Maxfield</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153185#c0">comment #0</a>)
<span class="quote">> TextRun::allowsRoundingHacks() and callers seem to be unused. It's exposed
> as WebView SPI, but no-one seems to use it. It's also exposed in Internals.</span >
It looks like Internals::resetToConsistentState() calls TextRun::setAllowsRoundingHacks(false) thereby forcibly disabling all rounding hacks for all layout tests.
There are some callers (RenderTheme, RenderFileUploadControl) who try to use rounding hacks; allowing them to use rounding hacks in LayoutTests will cause behavior change.
In the interest of testing what we're shipping, it seems that we should remove the flag and rebaseline the tests.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>