[Webkit-unassigned] [Bug 152728] AX: [Mac] Implement next/previous text marker functions using TextIterator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 16 11:12:26 PST 2016


--- Comment #16 from Nan Wang <n_wang at apple.com> ---
(In reply to comment #14)
> Comment on attachment 269022 [details]
> patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=269022&action=review
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:877
> > +    if (!textMarkerData.axID && !textMarkerData.ignored)
> should this be if (!textMarkerData.axID || !textMarkerData.ignored)

For the ignored element, I only set the ignored property, its axID is still 0. So || will return a nil which is not what we want. For a zeroed TextMarketData, the ignored property is false, so the empty data is not ignored by default.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160116/afe36ca4/attachment.html>

More information about the webkit-unassigned mailing list