<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] Implement next/previous text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=152728#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] Implement next/previous text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=152728">bug 152728</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152728#c14">comment #14</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=269022&action=diff" name="attach_269022" title="patch">attachment 269022</a> <a href="attachment.cgi?id=269022&action=edit" title="patch">[details]</a></span>
> patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=269022&action=review">https://bugs.webkit.org/attachment.cgi?id=269022&action=review</a>
>
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:877
> > + if (!textMarkerData.axID && !textMarkerData.ignored)
>
> should this be if (!textMarkerData.axID || !textMarkerData.ignored)</span >
For the ignored element, I only set the ignored property, its axID is still 0. So || will return a nil which is not what we want. For a zeroed TextMarketData, the ignored property is false, so the empty data is not ignored by default.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>