[Webkit-unassigned] [Bug 153117] [GTK OSX] libGObjectDOMBindings.a is not linked into libwebkit2gtk-4.0.37.dylib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153117

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269159|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #17 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 269159
  --> https://bugs.webkit.org/attachment.cgi?id=269159
Updated patch to also include feedback for removal of now-irrelevant build hack for gobject-intorspection

View in context: https://bugs.webkit.org/attachment.cgi?id=269159&action=review

> Source/WebKit2/ChangeLog:7
> +        Reviewed by Philip Chimento.

Philip is not a reviewer; this line has official significance, so please don't list people here unless they set the r+ flag in Bugzilla.

> Source/cmake/OptionsGTK.cmake:475
>  macro(ADD_WHOLE_ARCHIVE_TO_LIBRARIES _list_name)

It occurs to me that this macro does not belong in OptionsGTK.cmake as it has nothing to do with build options. Once we manage to land this patch, I will move it in a follow-up patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160116/54ee2859/attachment.html>