<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK OSX] libGObjectDOMBindings.a is not linked into libwebkit2gtk-4.0.37.dylib"
href="https://bugs.webkit.org/show_bug.cgi?id=153117">bug 153117</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #269159 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK OSX] libGObjectDOMBindings.a is not linked into libwebkit2gtk-4.0.37.dylib"
href="https://bugs.webkit.org/show_bug.cgi?id=153117#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK OSX] libGObjectDOMBindings.a is not linked into libwebkit2gtk-4.0.37.dylib"
href="https://bugs.webkit.org/show_bug.cgi?id=153117">bug 153117</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269159&action=diff" name="attach_269159" title="Updated patch to also include feedback for removal of now-irrelevant build hack for gobject-intorspection">attachment 269159</a> <a href="attachment.cgi?id=269159&action=edit" title="Updated patch to also include feedback for removal of now-irrelevant build hack for gobject-intorspection">[details]</a></span>
Updated patch to also include feedback for removal of now-irrelevant build hack for gobject-intorspection
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269159&action=review">https://bugs.webkit.org/attachment.cgi?id=269159&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:7
> + Reviewed by Philip Chimento.</span >
Philip is not a reviewer; this line has official significance, so please don't list people here unless they set the r+ flag in Bugzilla.
<span class="quote">> Source/cmake/OptionsGTK.cmake:475
> macro(ADD_WHOLE_ARCHIVE_TO_LIBRARIES _list_name)</span >
It occurs to me that this macro does not belong in OptionsGTK.cmake as it has nothing to do with build options. Once we manage to land this patch, I will move it in a follow-up patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>