[Webkit-unassigned] [Bug 153135] [EFL][GTK][WK2] Fix UIProcess build with GStreamer and without VIDEO

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 15 18:41:00 PST 2016


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #269114|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 269114
  --> https://bugs.webkit.org/attachment.cgi?id=269114

Hm, I see there's a significant amount of code in WebKitInstallMissingMediaPluginsPermissionRequest.cpp that is still guarded by ENABLE(VIDEO), so even though this compiles, this feature will surely be broken. Also, the permission request is never emitted due to the ENABLE(VIDEO) guard in WebKitWebView.cpp.

This code was added in r188121. At the time, I noticed the ENABLE_VIDEO guards but assumed that ENABLE_WEB_AUDIO depended on ENABLE_VIDEO; that is not correct. Carlos, what do you think about this?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160116/e551e2cc/attachment.html>

More information about the webkit-unassigned mailing list