<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL][GTK][WK2] Fix UIProcess build with GStreamer and without VIDEO"
href="https://bugs.webkit.org/show_bug.cgi?id=153135">bug 153135</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #269114 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL][GTK][WK2] Fix UIProcess build with GStreamer and without VIDEO"
href="https://bugs.webkit.org/show_bug.cgi?id=153135#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL][GTK][WK2] Fix UIProcess build with GStreamer and without VIDEO"
href="https://bugs.webkit.org/show_bug.cgi?id=153135">bug 153135</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269114&action=diff" name="attach_269114" title="Patch">attachment 269114</a> <a href="attachment.cgi?id=269114&action=edit" title="Patch">[details]</a></span>
Patch
Hm, I see there's a significant amount of code in WebKitInstallMissingMediaPluginsPermissionRequest.cpp that is still guarded by ENABLE(VIDEO), so even though this compiles, this feature will surely be broken. Also, the permission request is never emitted due to the ENABLE(VIDEO) guard in WebKitWebView.cpp.
This code was added in r188121. At the time, I noticed the ENABLE_VIDEO guards but assumed that ENABLE_WEB_AUDIO depended on ENABLE_VIDEO; that is not correct. Carlos, what do you think about this?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>