[Webkit-unassigned] [Bug 153116] Need ability to specify alternate image for AutoFill button in input fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153116

--- Comment #9 from Zach Li <zacharyli323 at gmail.com> ---
(In reply to comment #6)
> Comment on attachment 269073 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=269073&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:60
> > +WK_EXPORT void WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabled(WKBundleNodeHandleRef htmlInputElementHandle, bool enabled, WKAutoFillButtonType autoFillButtonType = WKAutoFillButtonTypeCredentials);
> 
> This will break nightlies. Notice that the nightlies launch system Safari
> with the nightly build of WebKit.

Nice catch, C does not support default argument actually. My approach will be name the new method as WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabledWithButtonType(WKBundleNodeHandleRef htmlInputElementHandle, bool enabled, WKAutoFillButtonType autoFillButtonType) and still keep the old method that takes two argument.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160116/c3e948b5/attachment.html>