<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Need ability to specify alternate image for AutoFill button in input fields"
href="https://bugs.webkit.org/show_bug.cgi?id=153116#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Need ability to specify alternate image for AutoFill button in input fields"
href="https://bugs.webkit.org/show_bug.cgi?id=153116">bug 153116</a>
from <span class="vcard"><a class="email" href="mailto:zacharyli323@gmail.com" title="Zach Li <zacharyli323@gmail.com>"> <span class="fn">Zach Li</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153116#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=269073&action=diff" name="attach_269073" title="Patch v1">attachment 269073</a> <a href="attachment.cgi?id=269073&action=edit" title="Patch v1">[details]</a></span>
> Patch v1
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=269073&action=review">https://bugs.webkit.org/attachment.cgi?id=269073&action=review</a>
>
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:60
> > +WK_EXPORT void WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabled(WKBundleNodeHandleRef htmlInputElementHandle, bool enabled, WKAutoFillButtonType autoFillButtonType = WKAutoFillButtonTypeCredentials);
>
> This will break nightlies. Notice that the nightlies launch system Safari
> with the nightly build of WebKit.</span >
Nice catch, C does not support default argument actually. My approach will be name the new method as WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabledWithButtonType(WKBundleNodeHandleRef htmlInputElementHandle, bool enabled, WKAutoFillButtonType autoFillButtonType) and still keep the old method that takes two argument.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>