[Webkit-unassigned] [Bug 136916] Pending API request URL no set when loading Alternate HTML or plain text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136916

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243974|review?                     |review+
              Flags|                            |

--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 243974
  --> https://bugs.webkit.org/attachment.cgi?id=243974
Now also including the xcode file changes

View in context: https://bugs.webkit.org/attachment.cgi?id=243974&action=review

I’m saying review+ but I’d still like to understand if Anders agrees about this use of "about:blank".

> Source/WebKit2/UIProcess/WebPageProxy.cpp:860
> +    auto transaction = m_pageLoadState.transaction();
> +    m_pageLoadState.setPendingAPIRequestURL(transaction, ASCIILiteral("about:blank"));

I think it’s a little peculiar to actually set the URL to about::blank here. Do we agree that explicitly giving it this particular URL makes sense? Does WebKit already treat this as if it came from that URL in other ways or is that a new concept we are introducing? If WebKit does already use this URL then why are we having to inject it specifically here?

I think this would read better without the local variable even though the other function does have it in a local variable since it uses it twice. I think blankURL().string() is better than ASCIILiteral("about:blank").

    m_pageLoadState.setPendingAPIRequestURL(m_pageLoadState.transaction(), blankURL().string());

> Source/WebKit2/UIProcess/WebPageProxy.cpp:875
> +    auto transaction = m_pageLoadState.transaction();
> +    m_pageLoadState.setPendingAPIRequestURL(transaction, ASCIILiteral("about:blank"));

Same comments as above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160115/f39bee7d/attachment.html>