<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Pending API request URL no set when loading Alternate HTML or plain text"
href="https://bugs.webkit.org/show_bug.cgi?id=136916">bug 136916</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #243974 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Pending API request URL no set when loading Alternate HTML or plain text"
href="https://bugs.webkit.org/show_bug.cgi?id=136916#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Pending API request URL no set when loading Alternate HTML or plain text"
href="https://bugs.webkit.org/show_bug.cgi?id=136916">bug 136916</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=243974&action=diff" name="attach_243974" title="Now also including the xcode file changes">attachment 243974</a> <a href="attachment.cgi?id=243974&action=edit" title="Now also including the xcode file changes">[details]</a></span>
Now also including the xcode file changes
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=243974&action=review">https://bugs.webkit.org/attachment.cgi?id=243974&action=review</a>
I’m saying review+ but I’d still like to understand if Anders agrees about this use of "about:blank".
<span class="quote">> Source/WebKit2/UIProcess/WebPageProxy.cpp:860
> + auto transaction = m_pageLoadState.transaction();
> + m_pageLoadState.setPendingAPIRequestURL(transaction, ASCIILiteral("about:blank"));</span >
I think it’s a little peculiar to actually set the URL to about::blank here. Do we agree that explicitly giving it this particular URL makes sense? Does WebKit already treat this as if it came from that URL in other ways or is that a new concept we are introducing? If WebKit does already use this URL then why are we having to inject it specifically here?
I think this would read better without the local variable even though the other function does have it in a local variable since it uses it twice. I think blankURL().string() is better than ASCIILiteral("about:blank").
m_pageLoadState.setPendingAPIRequestURL(m_pageLoadState.transaction(), blankURL().string());
<span class="quote">> Source/WebKit2/UIProcess/WebPageProxy.cpp:875
> + auto transaction = m_pageLoadState.transaction();
> + m_pageLoadState.setPendingAPIRequestURL(transaction, ASCIILiteral("about:blank"));</span >
Same comments as above.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>