[Webkit-unassigned] [Bug 153117] [GTK OSX] libGObjectDOMBindings.a is not linked into libwebkit2gtk-4.0.37.dylib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153117

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269043|                            |review+
              Flags|                            |

--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 269043
  --> https://bugs.webkit.org/attachment.cgi?id=269043
patch to add -Wl,-all_load

View in context: https://bugs.webkit.org/attachment.cgi?id=269043&action=review

Thanks for your patch! In the future, when you want a review for your patch, please set the r? flag for your patch. If you want us to commit your patch (which you do if you don't have committer access), set the cq? flag. You'll want to set cq? after answering this question:

> Source/cmake/OptionsGTK.cmake:477
> +        list(APPEND ${_list_name} -Wl,-all_load)

Should this be -Wl,-all_load ${library} -Wl,-no-all_load, or does it not work the same as --whole-archive?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160115/7c1cffca/attachment.html>