<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:mcatanzaro&#64;igalia.com" title="Michael Catanzaro &lt;mcatanzaro&#64;igalia.com&gt;"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK OSX] libGObjectDOMBindings.a is not linked into libwebkit2gtk-4.0.37.dylib"
   href="https://bugs.webkit.org/show_bug.cgi?id=153117">bug 153117</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #269043 Flags</td>
           <td>
               &nbsp;
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK OSX] libGObjectDOMBindings.a is not linked into libwebkit2gtk-4.0.37.dylib"
   href="https://bugs.webkit.org/show_bug.cgi?id=153117#c7">Comment # 7</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK OSX] libGObjectDOMBindings.a is not linked into libwebkit2gtk-4.0.37.dylib"
   href="https://bugs.webkit.org/show_bug.cgi?id=153117">bug 153117</a>
              from <span class="vcard"><a class="email" href="mailto:mcatanzaro&#64;igalia.com" title="Michael Catanzaro &lt;mcatanzaro&#64;igalia.com&gt;"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=269043&amp;action=diff" name="attach_269043" title="patch to add -Wl,-all_load">attachment 269043</a> <a href="attachment.cgi?id=269043&amp;action=edit" title="patch to add -Wl,-all_load">[details]</a></span>
patch to add -Wl,-all_load

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269043&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=269043&amp;action=review</a>

Thanks for your patch! In the future, when you want a review for your patch, please set the r? flag for your patch. If you want us to commit your patch (which you do if you don't have committer access), set the cq? flag. You'll want to set cq? after answering this question:

<span class="quote">&gt; Source/cmake/OptionsGTK.cmake:477
&gt; +        list(APPEND ${_list_name} -Wl,-all_load)</span >

Should this be -Wl,-all_load ${library} -Wl,-no-all_load, or does it not work the same as --whole-archive?</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>