[Webkit-unassigned] [Bug 153085] AX: Add a boundary value to AXTextStateChangeType

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 17:55:40 PST 2016


--- Comment #21 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 269010
  --> https://bugs.webkit.org/attachment.cgi?id=269010

View in context: https://bugs.webkit.org/attachment.cgi?id=269010&action=review

>>> Source/WebCore/editing/VisiblePosition.h:60
>>> +    VisiblePosition(bool boundary) : m_affinity(VP_DEFAULT_AFFINITY), m_isBoundary(boundary) { };
>> should this be "bool boundary = false" so you get the default behavior without changing code to be no?
>> or should we make a static boundaryVisiblePosition() class method that returns the right object
>> i know people don't generally like passing around bools where the value is not clear what its for
> If you want boundary to be false you can just call VisiblePosition(). I can do a static if you prefer but it feels odd to not use a constructor.

In this case no one would ever use VisiblePosition(false) because that's already exists, so it also feels weird to have a constructor with a parameter when it's not a necessary parameter

that's what I was thinking a 
static VisiblePosition visibleBoundaryPosition(); 
might be more clear

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160115/681b03ba/attachment-0001.html>

More information about the webkit-unassigned mailing list