<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add a boundary value to AXTextStateChangeType"
href="https://bugs.webkit.org/show_bug.cgi?id=153085#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add a boundary value to AXTextStateChangeType"
href="https://bugs.webkit.org/show_bug.cgi?id=153085">bug 153085</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269010&action=diff" name="attach_269010" title="Patch">attachment 269010</a> <a href="attachment.cgi?id=269010&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269010&action=review">https://bugs.webkit.org/attachment.cgi?id=269010&action=review</a>
<span class="quote">>>> Source/WebCore/editing/VisiblePosition.h:60
>>> + VisiblePosition(bool boundary) : m_affinity(VP_DEFAULT_AFFINITY), m_isBoundary(boundary) { };
>>
>> should this be "bool boundary = false" so you get the default behavior without changing code to be no?
>> or should we make a static boundaryVisiblePosition() class method that returns the right object
>>
>> i know people don't generally like passing around bools where the value is not clear what its for
>
> If you want boundary to be false you can just call VisiblePosition(). I can do a static if you prefer but it feels odd to not use a constructor.</span >
In this case no one would ever use VisiblePosition(false) because that's already exists, so it also feels weird to have a constructor with a parameter when it's not a necessary parameter
that's what I was thinking a
static VisiblePosition visibleBoundaryPosition();
might be more clear</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>