[Webkit-unassigned] [Bug 153108] WK1 and WK2 should share more candidate request code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153108

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269014|review?                     |review+
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 269014
  --> https://bugs.webkit.org/attachment.cgi?id=269014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269014&action=review

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:371
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200

Can we turn the __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 into some kind of feature #ifdef?

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1187
> +    // FIXME: Right now we only request candidates for spelling, replacement, and correction, but we plan to
> +    // support more types, and we will have to update this at that time.

I don't think this comment is useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160114/6c284ef3/attachment.html>