<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WK1 and WK2 should share more candidate request code"
href="https://bugs.webkit.org/show_bug.cgi?id=153108">bug 153108</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #269014 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WK1 and WK2 should share more candidate request code"
href="https://bugs.webkit.org/show_bug.cgi?id=153108#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WK1 and WK2 should share more candidate request code"
href="https://bugs.webkit.org/show_bug.cgi?id=153108">bug 153108</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269014&action=diff" name="attach_269014" title="Patch">attachment 269014</a> <a href="attachment.cgi?id=269014&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269014&action=review">https://bugs.webkit.org/attachment.cgi?id=269014&action=review</a>
<span class="quote">> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:371
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200</span >
Can we turn the __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 into some kind of feature #ifdef?
<span class="quote">> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1187
> + // FIXME: Right now we only request candidates for spelling, replacement, and correction, but we plan to
> + // support more types, and we will have to update this at that time.</span >
I don't think this comment is useful.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>