[Webkit-unassigned] [Bug 153040] WK2: Request completion candidates when needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153040

Enrica Casucci <enrica at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #268909|review?                     |review+
              Flags|                            |

--- Comment #7 from Enrica Casucci <enrica at apple.com> ---
Comment on attachment 268909
  --> https://bugs.webkit.org/attachment.cgi?id=268909
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268909&action=review

Looks good to me

> Source/WebCore/editing/Editor.cpp:3553
> +    RefPtr<Range> rangeForCurrentlyTypedString = candidateRangeForSelection(selection, m_frame);

I think you can have only one parameter (m_frame) to this function, since you compute the VisibleSelectionFrom it

> Source/WebCore/editing/Editor.cpp:3563
> +    RefPtr<Range> candidateRange = candidateRangeForSelection(selection, m_frame);

same here.

> Source/WebKit2/ChangeLog:10
> +        Mac need to support postLayoutData in order to have some layout-related 

typo needs

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160114/b0f4654e/attachment.html>