<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:enrica@apple.com" title="Enrica Casucci <enrica@apple.com>"> <span class="fn">Enrica Casucci</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WK2: Request completion candidates when needed"
href="https://bugs.webkit.org/show_bug.cgi?id=153040">bug 153040</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #268909 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WK2: Request completion candidates when needed"
href="https://bugs.webkit.org/show_bug.cgi?id=153040#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WK2: Request completion candidates when needed"
href="https://bugs.webkit.org/show_bug.cgi?id=153040">bug 153040</a>
from <span class="vcard"><a class="email" href="mailto:enrica@apple.com" title="Enrica Casucci <enrica@apple.com>"> <span class="fn">Enrica Casucci</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268909&action=diff" name="attach_268909" title="Patch">attachment 268909</a> <a href="attachment.cgi?id=268909&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268909&action=review">https://bugs.webkit.org/attachment.cgi?id=268909&action=review</a>
Looks good to me
<span class="quote">> Source/WebCore/editing/Editor.cpp:3553
> + RefPtr<Range> rangeForCurrentlyTypedString = candidateRangeForSelection(selection, m_frame);</span >
I think you can have only one parameter (m_frame) to this function, since you compute the VisibleSelectionFrom it
<span class="quote">> Source/WebCore/editing/Editor.cpp:3563
> + RefPtr<Range> candidateRange = candidateRangeForSelection(selection, m_frame);</span >
same here.
<span class="quote">> Source/WebKit2/ChangeLog:10
> + Mac need to support postLayoutData in order to have some layout-related </span >
typo needs</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>