[Webkit-unassigned] [Bug 153076] New: [GTK] Consistently use virtual and override specifiers in ScrollbarThemeGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153076

            Bug ID: 153076
           Summary: [GTK] Consistently use virtual and override specifiers
                    in ScrollbarThemeGtk
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org

Carlos made ScrollbarThemeGtk a final class, which I guess serves as an opt-in for new Clang warnings:

[4498/5928] Building CXX object Source...r/platform/gtk/ScrollbarThemeGtk.cpp.o
In file included from ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:27:
../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:63:10: warning: 'themeChanged' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void themeChanged();
         ^
../../Source/WebCore/platform/ScrollbarTheme.h:63:18: note: overridden virtual function is here
    virtual void themeChanged() {}
                 ^
1 warning generated.
[4500/5928] Building CXX object Source...GTK.dir/rendering/RenderThemeGtk.cpp.o
In file included from ../../Source/WebCore/rendering/RenderThemeGtk.cpp:48:
../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:63:10: warning: 'themeChanged' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void themeChanged();
         ^
../../Source/WebCore/platform/ScrollbarTheme.h:63:18: note: overridden virtual function is here
    virtual void themeChanged() {}
                 ^
1 warning generated.

While we're at it... most of these functions have redundant virtual specifiers and override, while the rest have only override. I prefer to omit virtual when unneeded, and we don't currently have consistency within WebKit, but most of the other functions here use it, so let's do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160113/8d3afa53/attachment.html>