<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Consistently use virtual and override specifiers in ScrollbarThemeGtk"
href="https://bugs.webkit.org/show_bug.cgi?id=153076">153076</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[GTK] Consistently use virtual and override specifiers in ScrollbarThemeGtk
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>Other
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebKit Gtk
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mcatanzaro@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>bugs-noreply@webkitgtk.org
</td>
</tr></table>
<p>
<div>
<pre>Carlos made ScrollbarThemeGtk a final class, which I guess serves as an opt-in for new Clang warnings:
[4498/5928] Building CXX object Source...r/platform/gtk/ScrollbarThemeGtk.cpp.o
In file included from ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:27:
../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:63:10: warning: 'themeChanged' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void themeChanged();
^
../../Source/WebCore/platform/ScrollbarTheme.h:63:18: note: overridden virtual function is here
virtual void themeChanged() {}
^
1 warning generated.
[4500/5928] Building CXX object Source...GTK.dir/rendering/RenderThemeGtk.cpp.o
In file included from ../../Source/WebCore/rendering/RenderThemeGtk.cpp:48:
../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:63:10: warning: 'themeChanged' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void themeChanged();
^
../../Source/WebCore/platform/ScrollbarTheme.h:63:18: note: overridden virtual function is here
virtual void themeChanged() {}
^
1 warning generated.
While we're at it... most of these functions have redundant virtual specifiers and override, while the rest have only override. I prefer to omit virtual when unneeded, and we don't currently have consistency within WebKit, but most of the other functions here use it, so let's do that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>