[Webkit-unassigned] [Bug 152959] [webkitdirs] Use CMake to determine architecture on isCMakeBuild()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152959

--- Comment #13 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 268655
  --> https://bugs.webkit.org/attachment.cgi?id=268655
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268655&action=review

>>>> Tools/Scripts/webkitdirs.pm:342
>>>>          $host_processor = `cmake --system-information | grep CMAKE_SYSTEM_PROCESSOR`;
>>> 
>>> We must not be running this on Windows.  I don't think we require grep to be installed.  If this doesn't break anything, then I guess it can stay, but I don't think this was a beneficial change.
>> 
>> If you want, I can fix it to avoid grep invocation, with pure perl.
> 
> Yes -- we must be running this and just not noticing the failure. Or, Cygwin 'grep' is getting used. We'd like to move off of Cygwin in the future, so making this a pure Perl implementation would be much better.
> 
> Could you do that as a separate bug, though?

I thought that win port is using Cygwin. Sorry for missing the plan. Anyway I just file a new bug for this instead - https://bugs.webkit.org/show_bug.cgi?id=152998.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160112/bc7db43b/attachment.html>