<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [webkitdirs] Use CMake to determine architecture on isCMakeBuild()"
href="https://bugs.webkit.org/show_bug.cgi?id=152959#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [webkitdirs] Use CMake to determine architecture on isCMakeBuild()"
href="https://bugs.webkit.org/show_bug.cgi?id=152959">bug 152959</a>
from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268655&action=diff" name="attach_268655" title="Patch">attachment 268655</a> <a href="attachment.cgi?id=268655&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268655&action=review">https://bugs.webkit.org/attachment.cgi?id=268655&action=review</a>
<span class="quote">>>>> Tools/Scripts/webkitdirs.pm:342
>>>> $host_processor = `cmake --system-information | grep CMAKE_SYSTEM_PROCESSOR`;
>>>
>>> We must not be running this on Windows. I don't think we require grep to be installed. If this doesn't break anything, then I guess it can stay, but I don't think this was a beneficial change.
>>
>> If you want, I can fix it to avoid grep invocation, with pure perl.
>
> Yes -- we must be running this and just not noticing the failure. Or, Cygwin 'grep' is getting used. We'd like to move off of Cygwin in the future, so making this a pure Perl implementation would be much better.
>
> Could you do that as a separate bug, though?</span >
I thought that win port is using Cygwin. Sorry for missing the plan. Anyway I just file a new bug for this instead - <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Support *grep* to check system architecture"
href="show_bug.cgi?id=152998">https://bugs.webkit.org/show_bug.cgi?id=152998</a>.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>