[Webkit-unassigned] [Bug 152038] Web Inspector: console.count() shouldn't show a colon in front of a number

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 10 11:31:18 PST 2016


Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
 Attachment #268646|review?                     |review-
              Flags|                            |

--- Comment #10 from Brian Burg <bburg at apple.com> ---
Comment on attachment 268646
  --> https://bugs.webkit.org/attachment.cgi?id=268646
Not quite sure if the empty string (`console.count("")`) should show `: 1` or if it should be equivalent to `console.count()`.

Looks like a good change, but the corresponding test needs to be rebaselined and edited to cover this change. The test is LayoutTests/inspector/console/console-api.html.

Please add the following cases (at least) to the test, to cover the counting functionality and the handling of whitespace/empty arguments.

console.count() // second time
console.count("    ")
console.count("") // second time
console.count("    ") // second time
console.count("counter title")
console.count("counter title") // second time

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160110/edd18db4/attachment.html>

More information about the webkit-unassigned mailing list