<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: console.count() shouldn't show a colon in front of a number"
href="https://bugs.webkit.org/show_bug.cgi?id=152038">bug 152038</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #268646 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: console.count() shouldn't show a colon in front of a number"
href="https://bugs.webkit.org/show_bug.cgi?id=152038#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: console.count() shouldn't show a colon in front of a number"
href="https://bugs.webkit.org/show_bug.cgi?id=152038">bug 152038</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268646&action=diff" name="attach_268646" title="Not quite sure if the empty string (`console.count("")`) should show `: 1` or if it should be equivalent to `console.count()`.">attachment 268646</a> <a href="attachment.cgi?id=268646&action=edit" title="Not quite sure if the empty string (`console.count("")`) should show `: 1` or if it should be equivalent to `console.count()`.">[details]</a></span>
Not quite sure if the empty string (`console.count("")`) should show `: 1` or if it should be equivalent to `console.count()`.
Looks like a good change, but the corresponding test needs to be rebaselined and edited to cover this change. The test is LayoutTests/inspector/console/console-api.html.
Please add the following cases (at least) to the test, to cover the counting functionality and the handling of whitespace/empty arguments.
console.count() // second time
console.count("")
console.count(" ")
console.count("") // second time
console.count(" ") // second time
console.count("counter title")
console.count("counter title") // second time</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>