[Webkit-unassigned] [Bug 152886] [mips] Add countLeadingZeros32 implementation in macro assembler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 8 17:31:34 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=152886

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 268538
  --> https://bugs.webkit.org/attachment.cgi?id=268538
Add countLeadingZeros32 implementation in mips macro assembler

View in context: https://bugs.webkit.org/attachment.cgi?id=268538&action=review

> Source/JavaScriptCore/assembler/MIPSAssembler.h:249
> +        RELEASE_ASSERT_NOT_REACHED();

I think this should be static_assert(false, "CLZ opcode is not available for this ISA"); so that someone will notice this when compiling instead of waiting to compile and do somewhat thorough testing on a device.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160109/ec5b11b2/attachment.html>


More information about the webkit-unassigned mailing list