<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] Add countLeadingZeros32 implementation in macro assembler"
href="https://bugs.webkit.org/show_bug.cgi?id=152886#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] Add countLeadingZeros32 implementation in macro assembler"
href="https://bugs.webkit.org/show_bug.cgi?id=152886">bug 152886</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268538&action=diff" name="attach_268538" title="Add countLeadingZeros32 implementation in mips macro assembler">attachment 268538</a> <a href="attachment.cgi?id=268538&action=edit" title="Add countLeadingZeros32 implementation in mips macro assembler">[details]</a></span>
Add countLeadingZeros32 implementation in mips macro assembler
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268538&action=review">https://bugs.webkit.org/attachment.cgi?id=268538&action=review</a>
<span class="quote">> Source/JavaScriptCore/assembler/MIPSAssembler.h:249
> + RELEASE_ASSERT_NOT_REACHED();</span >
I think this should be static_assert(false, "CLZ opcode is not available for this ISA"); so that someone will notice this when compiling instead of waiting to compile and do somewhat thorough testing on a device.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>