[Webkit-unassigned] [Bug 152884] [mips] Max value of immediate arg of logical ops is 0xffff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152884

Michael Saboff <msaboff at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #268536|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #4 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 268536
  --> https://bugs.webkit.org/attachment.cgi?id=268536
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268536&action=review

r=me

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:292
> -        else if (imm.m_value > 0 && imm.m_value < 65535 && !m_fixedWidth)
> +        else if (imm.m_value > 0 && imm.m_value <= 65535 && !m_fixedWidth)

This is fine, but you could also write:
    else if ((imm.m_value & 0xffff) == imm.m_value) && !m_fixedWidth)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160108/90fd36e5/attachment.html>