<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] Max value of immediate arg of logical ops is 0xffff"
href="https://bugs.webkit.org/show_bug.cgi?id=152884">bug 152884</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #268536 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] Max value of immediate arg of logical ops is 0xffff"
href="https://bugs.webkit.org/show_bug.cgi?id=152884#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] Max value of immediate arg of logical ops is 0xffff"
href="https://bugs.webkit.org/show_bug.cgi?id=152884">bug 152884</a>
from <span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268536&action=diff" name="attach_268536" title="Patch">attachment 268536</a> <a href="attachment.cgi?id=268536&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268536&action=review">https://bugs.webkit.org/attachment.cgi?id=268536&action=review</a>
r=me
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:292
> - else if (imm.m_value > 0 && imm.m_value < 65535 && !m_fixedWidth)
> + else if (imm.m_value > 0 && imm.m_value <= 65535 && !m_fixedWidth)</span >
This is fine, but you could also write:
else if ((imm.m_value & 0xffff) == imm.m_value) && !m_fixedWidth)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>