[Webkit-unassigned] [Bug 152865] [mips] Add new or32 implementation after r194613

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152865

--- Comment #5 from Julien Brianceau <jbriance at cisco.com> ---
Comment on attachment 268532
  --> https://bugs.webkit.org/attachment.cgi?id=268532
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268532&action=review

LGTM

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:381
> +        // TODO: Swap dataTempRegister and immTempRegister usage

Can you just add the (imm value == 0) check here to avoid load32/store32 in this case:

        if (!imm.m_value && !m_fixedWidth)
            return;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160108/2c4d5cbe/attachment.html>