<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [mips] Add new or32 implementation after r194613"
   href="https://bugs.webkit.org/show_bug.cgi?id=152865#c5">Comment # 5</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [mips] Add new or32 implementation after r194613"
   href="https://bugs.webkit.org/show_bug.cgi?id=152865">bug 152865</a>
              from <span class="vcard"><a class="email" href="mailto:jbriance&#64;cisco.com" title="Julien Brianceau &lt;jbriance&#64;cisco.com&gt;"> <span class="fn">Julien Brianceau</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=268532&amp;action=diff" name="attach_268532" title="Patch">attachment 268532</a> <a href="attachment.cgi?id=268532&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268532&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=268532&amp;action=review</a>

LGTM

<span class="quote">&gt; Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:381
&gt; +        // TODO: Swap dataTempRegister and immTempRegister usage</span >

Can you just add the (imm value == 0) check here to avoid load32/store32 in this case:

        if (!imm.m_value &amp;&amp; !m_fixedWidth)
            return;</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>