[Webkit-unassigned] [Bug 152865] [mips] Add new or32 implementation after r194613

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 17:44:06 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=152865

--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 268495
  --> https://bugs.webkit.org/attachment.cgi?id=268495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268495&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:384
> +        if (imm.m_value > 0 && imm.m_value < 65535

I'm no mips expert, but should this be <= 65535?  There are other places in MacroAssemblerMIPS.h where this is also < 65535, but don't they all work using the 16-bit immediate value if the immediate value is equal to 65535, too?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160108/8e0da486/attachment.html>


More information about the webkit-unassigned mailing list