[Webkit-unassigned] [Bug 152831] Enable selector filtering for shadow trees
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 7 09:10:21 PST 2016
https://bugs.webkit.org/show_bug.cgi?id=152831
Simon Fraser (smfr) <simon.fraser at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #268451|review? |review+
Flags| |
--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 268451
--> https://bugs.webkit.org/attachment.cgi?id=268451
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=268451&action=review
> Source/WebCore/css/RuleSet.cpp:229
> + // FIXME: Custom pseudo elements are handled but the shadow tree's selector filter. It doesn't know about the main DOM.
> + ruleData.disableSelectorFiltering();
The first part is not a complete sentence.
> Source/WebCore/css/SelectorFilter.cpp:57
> +bool SelectorFilter::parentStackIsConsistent(const ContainerNode* parentNode) const
Is it valid for parentNode to be null in this function?
> Source/WebCore/style/StyleTreeResolver.cpp:441
> + SelectorFilterParentPusher parentPusher(m_selectorFilter, slot);
> + parentPusher.push();
In other stack-based classes like this, the constructor would push by default, unless some argument told it not to.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160107/8935ed8a/attachment.html>
More information about the webkit-unassigned
mailing list