<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:simon.fraser&#64;apple.com" title="Simon Fraser (smfr) &lt;simon.fraser&#64;apple.com&gt;"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Enable selector filtering for shadow trees"
   href="https://bugs.webkit.org/show_bug.cgi?id=152831">bug 152831</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #268451 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Enable selector filtering for shadow trees"
   href="https://bugs.webkit.org/show_bug.cgi?id=152831#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Enable selector filtering for shadow trees"
   href="https://bugs.webkit.org/show_bug.cgi?id=152831">bug 152831</a>
              from <span class="vcard"><a class="email" href="mailto:simon.fraser&#64;apple.com" title="Simon Fraser (smfr) &lt;simon.fraser&#64;apple.com&gt;"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=268451&amp;action=diff" name="attach_268451" title="patch">attachment 268451</a> <a href="attachment.cgi?id=268451&amp;action=edit" title="patch">[details]</a></span>
patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268451&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=268451&amp;action=review</a>

<span class="quote">&gt; Source/WebCore/css/RuleSet.cpp:229
&gt; +            // FIXME: Custom pseudo elements are handled but the shadow tree's selector filter. It doesn't know about the main DOM.
&gt; +            ruleData.disableSelectorFiltering();</span >

The first part is not a complete sentence.

<span class="quote">&gt; Source/WebCore/css/SelectorFilter.cpp:57
&gt; +bool SelectorFilter::parentStackIsConsistent(const ContainerNode* parentNode) const</span >

Is it valid for parentNode to be null in this function?

<span class="quote">&gt; Source/WebCore/style/StyleTreeResolver.cpp:441
&gt; +        SelectorFilterParentPusher parentPusher(m_selectorFilter, slot);
&gt; +        parentPusher.push();</span >

In other stack-based classes like this, the constructor would push by default, unless some argument told it not to.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>