[Webkit-unassigned] [Bug 152786] Factor free standing tree style resolve functions into a class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 11:49:55 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=152786

--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
> It's odd that the filename and class name don't match. It think you should
> rename one of them.

I'm going to do renames separately.

> Ditto. Can inheritedStyle be const? Can Element& be const? Same for most of
> the other functions.

They should probably be const but that will require lots of changes (without introducing const_cast). It's better done separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160106/1f08708a/attachment.html>


More information about the webkit-unassigned mailing list