[Webkit-unassigned] [Bug 152664] [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152664

Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at webkit.org

--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
(In reply to comment #3)
> Comment on attachment 268140 [details]
> Added include_directories(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES)
> 
> Sorry for breaking this!
> 
> I am going to give cq- since this same construct exists in PlatformWin.cmake
> in this directory. Please fix it there too!

Do you mean that PlatformWin.cmake includes ${JavaScriptCore_INCLUDE_DIRECTORIES} ?

http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/shell/PlatformWin.cmake#L1

If so, I agree to remove it in PlatformWin.cmake although I don't know this patch is tightly related to remove it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160104/f33e7abb/attachment.html>