<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES"
href="https://bugs.webkit.org/show_bug.cgi?id=152664">bug 152664</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>gyuyoung.kim@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES"
href="https://bugs.webkit.org/show_bug.cgi?id=152664#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES"
href="https://bugs.webkit.org/show_bug.cgi?id=152664">bug 152664</a>
from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152664#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=268140&action=diff" name="attach_268140" title="Added include_directories(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES)">attachment 268140</a> <a href="attachment.cgi?id=268140&action=edit" title="Added include_directories(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES)">[details]</a></span>
> Added include_directories(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES)
>
> Sorry for breaking this!
>
> I am going to give cq- since this same construct exists in PlatformWin.cmake
> in this directory. Please fix it there too!</span >
Do you mean that PlatformWin.cmake includes ${JavaScriptCore_INCLUDE_DIRECTORIES} ?
<a href="http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/shell/PlatformWin.cmake#L1">http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/shell/PlatformWin.cmake#L1</a>
If so, I agree to remove it in PlatformWin.cmake although I don't know this patch is tightly related to remove it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>